Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always call Create DMG Variants from main branch #2305

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Mar 4, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206746813074878/f

Description:
Create DMG Variants pipeline is called by Publish DMG Release after deleting the release branch.
The variants workflow is then unavailable because the branch is gone.
This change fixes it by always calling Create DMG Variants from main branch.

Steps to test this PR:

  1. See the failed workflow for the 1.77.0 release which used 1.77.0 branch and failed on checking out the action inside create_variants.yml
  2. See the fixed workflow and verify that it uses create_variants.yml from the main branch

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy merged commit 5255ad5 into main Mar 4, 2024
19 checks passed
@ayoy ayoy deleted the dominik/fix-publish-release branch March 4, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants